RFR: 8364213: (bf) Improve java/nio/Buffer/CharBufferAsCharSequenceTest test comments [v4]
Brett Okken
duke at openjdk.org
Fri Aug 1 15:08:56 UTC 2025
On Fri, 1 Aug 2025 14:14:47 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> Which cases would you remove?
All of these:
https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java#L108-L182
As I walked through documenting what they cover, and then worked on breaking them out into smaller methods, they are just exercising the different types, at different ranges and offsets. I do not see a single scenario the static tests are covering which the dynamic/random tests do not. There are actually more combos covered with the random tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26512#discussion_r2248217647
More information about the nio-dev
mailing list