RFR: 8364213: (bf) Improve java/nio/Buffer/CharBufferAsCharSequenceTest test comments [v4]
Roger Riggs
rriggs at openjdk.org
Fri Aug 1 15:20:55 UTC 2025
On Fri, 1 Aug 2025 15:06:41 GMT, Brett Okken <duke at openjdk.org> wrote:
>> If they duplicate the random tests, then can be removed.
>> Which cases would you remove?
>
>> Which cases would you remove?
>
> All of these:
> https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java#L108-L182
>
> As I walked through documenting what they cover, and then worked on breaking them out into smaller methods, they are just exercising the different types, at different ranges and offsets. I do not see a single scenario the static tests are covering which the dynamic/random tests do not. There are actually more combos covered with the random tests.
Looks fine to remove those as duplicates.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26512#discussion_r2248242428
More information about the nio-dev
mailing list