RFR: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit [v3]
Brian Burkhalter
bpb at openjdk.org
Tue Jul 15 21:59:40 UTC 2025
On Tue, 15 Jul 2025 11:56:26 GMT, Brett Okken <duke at openjdk.org> wrote:
>> junit for CharSequence behavior of CharBuffer covering different CharBuffer implementations in various states (offset, position, limit)
>
> Brett Okken has updated the pull request incrementally with one additional commit since the last revision:
>
> add coverage for ByteBuffer as CharBuffer and test for codePoints
test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 137:
> 135: @ParameterizedTest
> 136: @MethodSource("charBufferArguments")
> 137: void testGetChars_range(CharSequence actual, char[] expected, int start, int stop, String description) {
Another small style point is that typically underscores are not used in (method) names in preference to camel case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2208788208
More information about the nio-dev
mailing list