RFR: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit [v3]

Brett Okken duke at openjdk.org
Wed Jul 16 15:42:41 UTC 2025


On Tue, 15 Jul 2025 21:40:07 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Brett Okken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add coverage for ByteBuffer as CharBuffer and test for codePoints
>
> test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 24:
> 
>> 22:  */
>> 23: 
>> 24: import static org.junit.jupiter.api.Assertions.assertEquals;
> 
> By convention, we typically put static imports _after_ regular imports.

addressed in https://github.com/openjdk/jdk/pull/26282/commits/0815146848eb847f51f5526e5cff6a531c371806

> test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 137:
> 
>> 135:     @ParameterizedTest
>> 136:     @MethodSource("charBufferArguments")
>> 137:     void testGetChars_range(CharSequence actual, char[] expected, int start, int stop, String description) {
> 
> Another small style point is that typically underscores are not used in (method) names in preference to camel case.

addressed in https://github.com/openjdk/jdk/pull/26282/commits/0815146848eb847f51f5526e5cff6a531c371806

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2210803670
PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2210804024


More information about the nio-dev mailing list