RFR: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit [v11]

Alan Bateman alanb at openjdk.org
Mon Jul 28 13:36:05 UTC 2025


On Fri, 25 Jul 2025 18:47:21 GMT, Brett Okken <duke at openjdk.org> wrote:

>> junit for CharSequence behavior of CharBuffer covering different CharBuffer implementations in various states (offset, position, limit)
>
> Brett Okken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   code review comments

test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 91:

> 89:         CharBuffer rndSlicedRange = randomizeRange(rndRange.slice());
> 90:         cases.add(Arguments.of(rndSlicedRange, buf, rndRange.position() + rndSlicedRange.position(), rndRange.position() + rndSlicedRange.limit(), type + " sliced at " + rndRange.position() + " with position " + rndSlicedRange.position() + " and limit " + rndSlicedRange.limit()));
> 91:     }

This line will mess up future side-by-side views, can you re-format it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2236498964


More information about the nio-dev mailing list