RFR: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit [v11]

Brett Okken duke at openjdk.org
Mon Jul 28 13:41:02 UTC 2025


On Mon, 28 Jul 2025 13:33:23 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brett Okken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   code review comments
>
> test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 91:
> 
>> 89:         CharBuffer rndSlicedRange = randomizeRange(rndRange.slice());
>> 90:         cases.add(Arguments.of(rndSlicedRange, buf, rndRange.position() + rndSlicedRange.position(), rndRange.position() + rndSlicedRange.limit(), type + " sliced at " + rndRange.position() + " with position " + rndSlicedRange.position() + " and limit " + rndSlicedRange.limit()));
>> 91:     }
> 
> This line will mess up future side-by-side views, can you re-format it?

@AlanBateman do I just create another PR linked to the same jira for this?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26282#discussion_r2236520173


More information about the nio-dev mailing list