RFR: 8364213: (bf) Improve java/nio/Buffer/GetChars.java test comments
Alan Bateman
alanb at openjdk.org
Tue Jul 29 15:51:55 UTC 2025
On Mon, 28 Jul 2025 16:43:05 GMT, Brett Okken <duke at openjdk.org> wrote:
> Address code review comments which came in post integration/merge of https://github.com/openjdk/jdk/pull/26282.
>
> Update/clarify test summary tag
> Document the values generated for arguments
> Move the endian-ness qualifier in the test descriptor string to not be first
> Change test method names to more closely match arg names of method under test
test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 104:
> 102: * <li>String - description of the test scenario</li>
> 103: * </ul>
> 104: */
That helps a bit but I think we need to break up charBufferArguments into simpler/maintainable methods that have clear comments to document the test cases that they generate. Right now it's just way too hard to see what is tested and not tested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26512#discussion_r2240275588
More information about the nio-dev
mailing list