RFR: 8364213: (bf) Improve java/nio/Buffer/GetChars.java test comments [v2]

[Brett Okken]

On Tue, 29 Jul 2025 15:49:33 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brett Okken has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - whitespace
>>  - better documentation for "random" test cases
>>    
>>    fix for random range generation (JDK-8364345)
>
> test/jdk/java/nio/Buffer/CharBufferAsCharSequenceTest.java line 104:
> 
>> 102:      * <li>String - description of the test scenario</li>
>> 103:      * </ul>
>> 104:      */
> 
> That helps a bit but I think we need to break up charBufferArguments into simpler/maintainable methods that have clear comments to document the test cases that they generate. Right now it's just way too hard to see what is tested and not tested.

I have started by adding more documentation to the "random" tests.
I agree this makes it much easier to reason about what scenarios are covered.
It is actually making me wonder if the "static" tests are even worth keeping.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26512#discussion_r2243010510