RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v6]

Kim Barrett kbarrett at openjdk.org
Sun Jun 29 20:22:49 UTC 2025


On Fri, 27 Jun 2025 20:57:01 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into direct-buffer-cleaner
>>  - Merge branch 'master' into direct-buffer-cleaner
>>  - Merge branch 'master' into direct-buffer-cleaner
>>  - Merge branch 'master' into direct-buffer-cleaner
>>  - add description of BufferCleaner class
>>  - exception handling in cleaner for backward consistency
>>  - detabify
>>  - move jdk.internal.nio.Cleaner to sun.nio
>>  - copyrights
>>  - remove java.nio use of jdk.internal.ref.Cleaner
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/08e8748d...c995d97e
>
> src/java.base/share/classes/java/nio/BufferCleaner.java line 88:
> 
>> 86:     }
>> 87: 
>> 88:     // Cribbed from jdk.internal.ref.CleanerImpl.
> 
> Maybe sometime later this can be shared instead of copied.

>From the PR description:
> Possible future work would merge the two into a common utility.

I intend to file a JBS issue for that if this change is approved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25289#discussion_r2173903661


More information about the nio-dev mailing list