RFR: 8344332: (bf) Migrate DirectByteBuffer away from jdk.internal.ref.Cleaner [v6]

Kim Barrett kbarrett at openjdk.org
Sun Jun 29 20:26:48 UTC 2025


On Fri, 27 Jun 2025 21:06:03 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into direct-buffer-cleaner
>>  - Merge branch 'master' into direct-buffer-cleaner
>>  - Merge branch 'master' into direct-buffer-cleaner
>>  - Merge branch 'master' into direct-buffer-cleaner
>>  - add description of BufferCleaner class
>>  - exception handling in cleaner for backward consistency
>>  - detabify
>>  - move jdk.internal.nio.Cleaner to sun.nio
>>  - copyrights
>>  - remove java.nio use of jdk.internal.ref.Cleaner
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/e986d49b...c995d97e
>
> src/java.base/share/classes/java/nio/BufferCleaner.java line 243:
> 
>> 241:                 return;
>> 242:             }
>> 243:             cleaningThread = new CleaningThread();
> 
> I think double-checked locking could work well here.

Sure, but why bother?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25289#discussion_r2173904629


More information about the nio-dev mailing list