Swap should be better done native?

Ulf Zibis Ulf.Zibis at gmx.de
Thu Apr 1 17:04:27 PDT 2010


Am 01.04.2010 01:29, schrieb Martin Buchholz:
> On Wed, Mar 31, 2010 at 16:11, Ulf Zibis<Ulf.Zibis at gmx.de>  wrote:
>    
>> Not to forget java.nio.Heap-X-Buffer.java.template.
>>      
> Ulf, would you like to provide a patch that deletes all uses of
> java.nio.Bits.swap and replaces them with the relevant
> reverseBytes methods?

See attachments.

Number_reverseBytes:
- Most, but not all, i.e. Float, Double, SIZE constants were at "wrong" 
position. I have corrected this.
- I too think, serialVersionIDs should be positioned more upper, e.g. as 
last of all static finals.

X-Buffer_swap:
- I'm not enough experienced in make files, and I can't run them on my 
Windows system, so genBuffer.sh change is incomplete.

-Ulf

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Number_reverseBytes
Url: http://mail.openjdk.java.net/pipermail/nio-discuss/attachments/20100402/e1b33845/attachment-0002.ksh 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: X-Buffer_swap
Url: http://mail.openjdk.java.net/pipermail/nio-discuss/attachments/20100402/e1b33845/attachment-0003.ksh 


More information about the nio-discuss mailing list