[REVIEW REQUEST] Add userData property and properties map to TableColumn class

Jonathan Giles jonathan.giles at oracle.com
Mon Apr 23 12:47:41 PDT 2012


I've had no feedback on this tweak. I assume that is because it is a 
no-brainer. I am now seeking a +1 from Richard. As with the last email, 
I will follow normal procedure and give 24 hours notice for this, and 
will otherwise assume approval by neglect :-)

-- Jonathan


On 18/04/2012 12:15 p.m., Jonathan Giles wrote:
> Hi all,
>
> A simple API addition request for your pondering today:
>
> http://javafx-jira.kenai.com/browse/RT-20956
>
> This RFE asks for the userData property to be added to TableColumn. 
> userData is a property on Node, and in fact is just a shortcut to 
> setting a property in the Node.properties map. Therefore, I would like 
> to expose both userData and the properties map on TableColumn. I can 
> see the value in adding this in, and there is a patch attached to the 
> Jira issue above that adds this in.
>
> This API has already been added to another 'non-control' (i.e. a class 
> in the controls package that doesn't extend from Control, and thus 
> Node) - the MenuItem class has both the userData property and the 
> properties map. It could be argued that this should be against all 
> controls that do not extend Control (including TableColumn, Tab, and 
> the MenuItem classes from memory), but for now I'm taking it on a 
> case-by-case base. I'm totally happen to be asked to add this API to 
> Tab as well, if people want, as it is now the only outlier.
>


More information about the openjfx-dev mailing list