hg: openjfx/8/graphics/rt: 2 new changesets

[Milan Kubec]

Hello,
see following discussion:
http://javafx-jira.kenai.com/browse/RT-25795

I personally thought that behavior in 2.x was not correct, but the
document mentioned in the issue says it's copied to Node.id and
SceneBuilder has already build some fuctionality around it, so it must
be treated as a contract.

The behavior was restored already by rollback of fix for issue
http://javafx-jira.kenai.com/browse/RT-23519 and this fix is about fx:id
overriding Node.id.

  Milan


Dne 3.1.2013 12:16, Tom Schindl napsal(a):
> Hi,
>
> I wonder if translating fx:id to Node.setId() is a good idea (it was
> this way in 2.x, but changed in 8.x until this commit if i read it get
> correctly).
>
> One could have argued that this is a regression - although I think fx:id
> has never been speced to set the Node.id-attribute - but I personally
> liked the change because fx:id should only bring something into the
> namespace so that it could be injected into the controller.
>
> Tom
>
> Am 03.01.13 11:47, schrieb hang.vo at oracle.com:
>> Changeset: 637214644dc8
>> Author:    Milan Kubec <milan.kubec at oracle.com>
>> Date:      2013-01-03 09:18 +0000
>> URL:       http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/637214644dc8
>>
>> fx:id is set as value for Node.id only if Node.id was not previously set during processing of start element attributes; id renamed to fx_id to lessen confusion
>>
>> ! javafx-fxml/src/javafx/fxml/FXMLLoader.java
>>
>> Changeset: 1b7e12459a11
>> Author:    Milan Kubec <milan.kubec at oracle.com>
>> Date:      2013-01-03 10:39 +0000
>> URL:       http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/1b7e12459a11
>>
>> Automated merge with ssh://jfxsrc.us.oracle.com//javafx/8.0/scrum/graphics/jfx////rt
>>
>>
>