[Review] RT-27467 - Add and improve scrollTo API

Richard Bair richard.bair at oracle.com
Fri Jan 18 08:14:13 PST 2013


> I'd like to request review to add the following API:
> 
> - ScrollToEvent<T>
> 
> - ScrollPane:
> * scrollTo(Node): void
> * setOnScrollTo(EventHandler<ScrollToEvent<Node>>): void
> * getOnScrollTo(): EventHandler<ScrollToEvent<Node>>
> *  onScrollToProperty(): ObjectProperty<EventHandler<ScrollToEvent<Node>>>
> 
> 
> 
> And retrofit ListView, TableView, TreeTableView, TreeView with to this
> API by adding:
> * setOnScrollTo(EventHandler<ScrollToEvent<Integer>> value):void
> * getOnScrollTo(): EventHandler<ScrollToEvent<Integer>>
> * onScrollToProperty(): ObjectProperty<EventHandler<ScrollToEvent<Integer>>>
> 
> For the view classes this means one can observe manually scrollTo(int) now.

Looks good.


> I'm still unable to attach patches to JIRA so you can see a diff against
> master in my bitbucket clone at
> https://bitbucket.org/tschindl/jfx-rt/compare/RT-27467..local-compile#diff

I love looking at the patches on bit bucket so I think that's fine (some time this year we're supposed to get a proper code-review system and such for openjfx / openjdk, but until then this works fine I think).

Richard


More information about the openjfx-dev mailing list