[Review] RT-27467 - Add and improve scrollTo API

John Hendrikx hjohn at xs4all.nl
Sun Jan 20 13:27:37 PST 2013


This looks okay to me.

It still raises the question where the API is that makes scrollTo() 
predictable and restorable.  Currently there is no way to capture the 
exact position of a view and restore it to its exact previous position.

--John

On 18/01/2013 12:13, Tom Schindl wrote:
> Hi,
>
> See http://javafx-jira.kenai.com/browse/RT-27467 for more information.
>
> I'd like to request review to add the following API:
>
> - ScrollToEvent<T>
>
> - ScrollPane:
> * scrollTo(Node): void
> * setOnScrollTo(EventHandler<ScrollToEvent<Node>>): void
> * getOnScrollTo(): EventHandler<ScrollToEvent<Node>>
> *  onScrollToProperty(): ObjectProperty<EventHandler<ScrollToEvent<Node>>>
>
>
>
> And retrofit ListView, TableView, TreeTableView, TreeView with to this
> API by adding:
> * setOnScrollTo(EventHandler<ScrollToEvent<Integer>>  value):void
> * getOnScrollTo(): EventHandler<ScrollToEvent<Integer>>
> * onScrollToProperty(): ObjectProperty<EventHandler<ScrollToEvent<Integer>>>
>
> For the view classes this means one can observe manually scrollTo(int) now.
>
> I'm still unable to attach patches to JIRA so you can see a diff against
> master in my bitbucket clone at
> https://bitbucket.org/tschindl/jfx-rt/compare/RT-27467..local-compile#diff
>
> Tom
>



More information about the openjfx-dev mailing list