[Review] RT-27467 - Add and improve scrollTo API

[Tom Schindl]

I'm not sure but if I read the code appropriately you can set the vvalue
and hvalue so so you can scroll to any position in a ScrollPane, or are
you talking about *View classes?

Tom

Am 20.01.13 22:27, schrieb John Hendrikx:
> This looks okay to me.
> 
> It still raises the question where the API is that makes scrollTo()
> predictable and restorable.  Currently there is no way to capture the
> exact position of a view and restore it to its exact previous position.
> 
> --John
> 
> On 18/01/2013 12:13, Tom Schindl wrote:
>> Hi,
>>
>> See http://javafx-jira.kenai.com/browse/RT-27467 for more information.
>>
>> I'd like to request review to add the following API:
>>
>> - ScrollToEvent<T>
>>
>> - ScrollPane:
>> * scrollTo(Node): void
>> * setOnScrollTo(EventHandler<ScrollToEvent<Node>>): void
>> * getOnScrollTo(): EventHandler<ScrollToEvent<Node>>
>> *  onScrollToProperty():
>> ObjectProperty<EventHandler<ScrollToEvent<Node>>>
>>
>>
>>
>> And retrofit ListView, TableView, TreeTableView, TreeView with to this
>> API by adding:
>> * setOnScrollTo(EventHandler<ScrollToEvent<Integer>>  value):void
>> * getOnScrollTo(): EventHandler<ScrollToEvent<Integer>>
>> * onScrollToProperty():
>> ObjectProperty<EventHandler<ScrollToEvent<Integer>>>
>>
>> For the view classes this means one can observe manually scrollTo(int)
>> now.
>>
>> I'm still unable to attach patches to JIRA so you can see a diff against
>> master in my bitbucket clone at
>> https://bitbucket.org/tschindl/jfx-rt/compare/RT-27467..local-compile#diff
>>
>>
>> Tom
>>
> 


-- 
B e s t S o l u t i o n . a t                        EDV Systemhaus GmbH
------------------------------------------------------------------------
tom schindl                 geschäftsführer/CEO
------------------------------------------------------------------------
eduard-bodem-gasse 5-7/1   A-6020 innsbruck     fax      ++43 512 935833
http://www.BestSolution.at                      phone    ++43 512 935834