Review for RT-38968

Chris Bensen chris.bensen at oracle.com
Mon Oct 13 20:50:02 UTC 2014


From what I’ve seen, jvmuserarg.0 never exists. It is 1 based. If you are however changing it to 0 based then this line is fine:

-        TString prefix = TString(_T("jvmuserarg.")) + PlatformString(index).toString();
+        TString prefix = TString(_T("jvmuserarg.")) + PlatformString(index + 1).toString();
Otherwise it is not.

Chris



On Oct 13, 2014, at 1:23 PM, Danno Ferrin <danno.ferrin at oracle.com> wrote:

> Chris, Kevin, 
> 
> Please review this patch.  More info in the JIRA
> 
> Webrev: http://cr.openjdk.java.net/~shemnon/RT-38968/webrev.00/
> JIRA: https://javafx-jira.kenai.com/browse/RT-38968



More information about the openjfx-dev mailing list