[9] Review request for 8157002: Toggle gtk version if SWT used via FXCanvas

Semyon Sadetsky semyon.sadetsky at oracle.com
Wed Nov 23 09:13:58 UTC 2016


Thanks, Doychin.

The webrev is updated: 
http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.01/

--Semyon


On 11/23/2016 10:15 AM, Doychin Bondzhev wrote:
> Hi,
>
> I think this line is incorrect:
>
> if (ver < 2 && ver > 3) {
>
> It should be || instead of &&
>
> On 22.11.2016 г. 15:51 ч., Semyon Sadetsky wrote:
>> Hello Kevin & David,
>>
>> Please review the fix for jfx9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8157002
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.00/
>>
>> In JFX embeded into SWT scenarios JFX loads GTK primarily. So SWT GTK
>> version cannot be detected using the check for the loaded native library
>> version.
>>
>> The fix proposes a way to detect if GTK version of swt.jar library is
>> available on the classpath and tries to get the GTK version from SWT lib
>> internal java classes.
>>
>> --Semyon
>>
>>
>
>



More information about the openjfx-dev mailing list