[9] Review request: 8170701: Update FXML documentation for setAccessible

Kevin Rushforth kevin.rushforth at oracle.com
Mon Mar 6 15:11:04 UTC 2017



Mandy Chung wrote:
>> On Mar 4, 2017, at 5:14 PM, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
>>
>> http://cr.openjdk.java.net/~kcr/8170701/webrev.01/
>>
>>     
>
>   40  * object {@link Module#isOpen opens} the containing package to the
>
> Nit: s/@link/@linkplain
>
>   41  * {@code javafx.fxml} module, either in its {@link ModuleDescriptor}
>   42  * (module-info.class) or by calling {@link Module#addOpens}.
>
> Do you intend to take out “(module-info.class)”?  
>   

I was thinking to leave it in, since module-info.class is the most 
common way to specify a ModuleDescription. Maybe better would be:

    @{link ModuleDescriptor} (e.g., in its module-info.class)

>   43  * An object is also reflectively accessible if it is declared as public,
>
> Does “it” mean its constructor?
>   

No. It means the declaration itself, for example:

    @FXML
    public String myString;


as opposed to:

    @FXML
    private String myString;

-- Kevin


>   44  * is in a public class, and the module containing that class
>   45  * {@link Module#isExported(String,Module) exports}
>
> Nit: s/@link/@linkplain
>
>   46  * the containing package to the {@code javafx.fxml} module.
>
> This is word-smithing and formatting nit.  No need to send a new webrev.
>
> Mandy


More information about the openjfx-dev mailing list