Review-Request for JDK-8207370
Kevin Rushforth
kevin.rushforth at oracle.com
Tue Jul 24 16:00:35 UTC 2018
Thanks for checking. On my system, I get 0 failures after the fix.
Regarding the 1 failure you see: the tests are known to be unstable,
which is why they are skipped by default. This test instability is
covered by JDK-8196607 [1]. Does this explain the failure you are seeing?
-- Kevin
[1] https://bugs.openjdk.java.net/browse/JDK-8196607
On 7/24/2018 8:54 AM, Johan Vos wrote:
> Using the proposed patch, there is only 1 failure instead of 12.
> I suggest to create a separate issue for that 1 failure, as the patch
> indeed fixes the assertEquals issue.
>
> Op di 24 jul. 2018 om 16:18 schreef Kevin Rushforth
> <kevin.rushforth at oracle.com <mailto:kevin.rushforth at oracle.com>>:
>
> The following should work:
>
> gradle -PFULL_TEST=true -PUSE_ROBOT=true -PUNSTABLE_TEST=true
> :systemTests:test
>
> You can limit it to just the Monocle tests as follows:
>
> gradle -PFULL_TEST=true -PUSE_ROBOT=true -PUNSTABLE_TEST=true
> :systemTests:test --tests 'test.robot.com.sun.glass.ui.monocle.*'
>
> -- Kevin
>
> On 7/24/2018 5:42 AM, Johan Vos wrote:
> > Hi Michael,
> >
> > Excuse me for the simple question, but how to you enable those
> tests (as
> > in: what options do you provide to gradle)?
> > Fix looks trivial to me, but want to double check.
> >
> > - Johan
> >
> > On Mon, Jul 23, 2018 at 11:36 PM Michael Ennen
> <mike.ennen at gmail.com <mailto:mike.ennen at gmail.com>> wrote:
> >
> >> Hi,
> >>
> >> I'd like to request a review for JDK-8207370 available
> >> as a PR on Github:
> >>
> >> https://github.com/javafxports/openjdk-jfx/pull/135
> >>
> >> Thanks.
> >>
> >> --
> >> Michael Ennen
> >>
>
More information about the openjfx-dev
mailing list