Review-Request for JDK-8207370

[Johan Vos]

Running the tests again got 0 failures.
The previous failure was:
test.robot.com.sun.glass.ui.monocle.RotateTest >
testRotateLeftByFewSmallSteps[1] FAILED
    com.sun.glass.ui.monocle.TestLogShim$TestLogAssertion: Timed out after
3000ms waiting for 'TouchPoint: PRESSED 640, 40'
        at
javafx.graphics/com.sun.glass.ui.monocle.TestLogShim.waitForLog(TestLogShim.java:211)
        at
javafx.graphics/com.sun.glass.ui.monocle.TestLogShim.waitForLogContaining(TestLogShim.java:237)
        at
javafx.graphics/com.sun.glass.ui.monocle.TestLogShim.waitForLogContaining(TestLogShim.java:246)
        at
test.robot.com.sun.glass.ui.monocle.RotateTest.Rotate(RotateTest.java:121)
        at
test.robot.com.sun.glass.ui.monocle.RotateTest.Rotate(RotateTest.java:226)
        at
test.robot.com.sun.glass.ui.monocle.RotateTest.testRotateLeftByFewSmallSteps(RotateTest.java:287)


I ran that test a number of times, but it never failed. Might look again
later, as we are still using monocle on Android.

- Johan

Op di 24 jul. 2018 om 18:00 schreef Kevin Rushforth <
kevin.rushforth at oracle.com>:

> Thanks for checking. On my system, I get 0 failures after the fix.
>
> Regarding the 1 failure you see: the tests are known to be unstable, which
> is why they are skipped by default. This test instability is covered by
> JDK-8196607 [1]. Does this explain the failure you are seeing?
>
> -- Kevin
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8196607
>
>
>
> On 7/24/2018 8:54 AM, Johan Vos wrote:
>
> Using the proposed patch, there is only 1 failure instead of 12.
> I suggest to create a separate issue for that 1 failure, as the patch
> indeed fixes the assertEquals issue.
>
> Op di 24 jul. 2018 om 16:18 schreef Kevin Rushforth <
> kevin.rushforth at oracle.com>:
>
>> The following should work:
>>
>>      gradle -PFULL_TEST=true -PUSE_ROBOT=true -PUNSTABLE_TEST=true
>> :systemTests:test
>>
>> You can limit it to just the Monocle tests as follows:
>>
>>      gradle -PFULL_TEST=true -PUSE_ROBOT=true -PUNSTABLE_TEST=true
>> :systemTests:test --tests 'test.robot.com.sun.glass.ui.monocle.*'
>>
>> -- Kevin
>>
>> On 7/24/2018 5:42 AM, Johan Vos wrote:
>> > Hi Michael,
>> >
>> > Excuse me for the simple question, but how to you enable those tests (as
>> > in: what options do you provide to gradle)?
>> > Fix looks trivial to me, but want to double check.
>> >
>> > - Johan
>> >
>> > On Mon, Jul 23, 2018 at 11:36 PM Michael Ennen <mike.ennen at gmail.com>
>> wrote:
>> >
>> >> Hi,
>> >>
>> >> I'd like to request a review for JDK-8207370 available
>> >> as a PR on Github:
>> >>
>> >> https://github.com/javafxports/openjdk-jfx/pull/135
>> >>
>> >> Thanks.
>> >>
>> >> --
>> >> Michael Ennen
>> >>
>>
>>
>