[Rev 01] RFR: 8207759: VK_ENTER not consumed by TextField when default Button exists

[Jeanette Winzenburg]

On Tue, 10 Dec 2019 12:03:03 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextInputControlBehavior.java line 626:
> 
>> 625:     protected void fire(KeyEvent event) { } // TODO move to TextFieldBehavior
>> 626:     protected void cancelEdit(KeyEvent event) { };
>> 627: 
> 
> Will this code removal re-introduce JDK-8145515?

no don't think so: the fix for JDK-8145515 was to prevent the triggering of parent.fireEvent, so removing the method altogether should have no effect :) Could add a test to explicitly guard against this.

Please note that the old combo issue is back in the form of https://bugs.openjdk.java.net/browse/JDK-8229914 - before and after fixing this, combo does very bad things ;)

-------------

PR: https://git.openjdk.java.net/jfx/pull/15