RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle. [v5]
Kevin Rushforth
kcr at openjdk.java.net
Thu Aug 13 19:42:15 UTC 2020
On Fri, 7 Aug 2020 21:34:49 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> JDK-8241840
>> The tests are now reused for native and monocle tests.
>
> tests/system/src/test/java/test/javafx/stage/FocusedWindowMonocleTest.java line 56:
>
>> 55: }
>> 56: }
>
> Minor: Add missing newline
I meant that the file should end with a newline (it doesn't matter whether or not there is a newline before the final
closing brace). The red circle with a `-` in it is GitHub's way of showing you that the file doesn't end with a newline.
> tests/system/src/test/java/test/javafx/stage/FocusedWindowNativeTest.java line 52:
>
>> 51: }
>> 52: }
>
> Minor: Add missing newline
Same as in previous file.
> tests/system/src/test/java/test/javafx/stage/FocusedWindowTestBase.java line 106:
>
>> 105: }
>> 106: }
>
> Minor: Add missing newline
Same as in previous file.
-------------
PR: https://git.openjdk.java.net/jfx/pull/153
More information about the openjfx-dev
mailing list