RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle. [v5]

Florian Kirmaier fkirmaier at openjdk.java.net
Fri Aug 14 10:09:30 UTC 2020


On Thu, 13 Aug 2020 19:26:47 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> tests/system/src/test/java/test/javafx/stage/FocusedWindowMonocleTest.java line 56:
>> 
>>> 55:     }
>>> 56: }
>> 
>> Minor: Add missing newline
>
> I meant that the file should end with a newline (it doesn't matter whether or not there is a newline before the final
> closing brace). The red circle with a `-` in it is GitHub's way of showing you that the file doesn't end with a newline.

done

>> tests/system/src/test/java/test/javafx/stage/FocusedWindowTestBase.java line 106:
>> 
>>> 105:     }
>>> 106: }
>> 
>> Minor: Add missing newline
>
> Same as in previous file.

done

>> tests/system/src/test/java/test/javafx/stage/FocusedWindowNativeTest.java line 52:
>> 
>>> 51:     }
>>> 52: }
>> 
>> Minor: Add missing newline
>
> Same as in previous file.

done

-------------

PR: https://git.openjdk.java.net/jfx/pull/153


More information about the openjfx-dev mailing list