RFR: 8193800: TreeTableView selection changes on sorting [v6]

Ambarish Rapte arapte at openjdk.java.net
Fri Jun 26 09:23:13 UTC 2020


On Thu, 25 Jun 2020 22:44:18 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment corrections, adding new tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java line 400:
> 
>> 399:
>> 400:     @Ignore("JDK-8248217")
>> 401:     @Test public void testSelectionUpdatesCorrectlyAfterRemovingSelectedItem() {
> 
> Question: did you mean to point to the umbrella Task or is there a more specific bug that you could point to (I think
> referring to the Task is fine if you aren't sure). This applies to all of the newly added `@Ignore`d tests.

These ignored tests are related to removing and adding a TreeItem.
I have corrected the id to use JDK-8193442 for the tests that remove an item and created a new JBS issue JDK-8248389,
and used it for the test of adding an item .

-------------

PR: https://git.openjdk.java.net/jfx/pull/244


More information about the openjfx-dev mailing list