RFR: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic letter.

[Kevin Rushforth]

On Mon, 23 Mar 2020 06:36:26 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

> **Bug :**
> https://bugs.openjdk.java.net/browse/JDK-8089828
> 
> **Root Cause :**
> RIGHT_TO_LEFT NodeOrientation was not considered during mnemonic position calculation.
> 
> **Fix :**
> Corrected code to consider RIGHT_TO_LEFT NodeOrientation while calculating mnemonic position.
> 
> **Testing :**
> Existing manual test is modified to test RTL buttons as well.

The fix looks good to me, although I'd like a second reviewer.

I did note one issue with the format of the copyright year.

tests/manual/UI/ButtonMnemonicPositionTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2017, 2020 Oracle and/or its affiliates. All rights reserved.
> 3:  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

There is a missing `,` after `2020`

-------------

PR: https://git.openjdk.java.net/jfx/pull/146