[Rev 01] RFR: 8244112: Skin implementations: must not violate contract of dispose

[Ambarish Rapte]

On Mon, 11 May 2020 04:51:51 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup
>>   
>>   - corrected incorrect bug id in commented
>>   - removed unrelated test change from TextAreaTest
>>   - updated copyright year
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuButtonSkinBase.java line 222:
> 
>> 221:         // FIXME : JDK-8244112 - backout if we are already disposed
>> 222:         // should check for getSkinnable to be null and return
>> 223:         if (getSkinnable() == null) return;
> 
> This comment can be removed. FIXME is getting fixed. :)

Ajit has already commented about it, please resolve this comment.

-------------

PR: https://git.openjdk.java.net/jfx/pull/209