[Rev 01] RFR: 8244112: Skin implementations: must not violate contract of dispose

[Jeanette Winzenburg]

On Wed, 13 May 2020 10:09:40 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Jeanette Winzenburg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup
>>   
>>   - corrected incorrect bug id in commented
>>   - removed unrelated test change from TextAreaTest
>>   - updated copyright year
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinDisposeContractTest.java line 159:
> 
>> 158:             {TreeTableView.class, },
>> 159:             {TreeView.class, },
>> 160:         };
> 
> Should these controls be included too: `Tooltip`, `HTMLEditor`, `ContextMenu` ?

good catch :)

Hmm .. thinking aloud:

- all in web is a bit very different as a small layer on top of the webEngine, usually off my radar
- the skinnable windows are no controls

so the easy way out - which I would tend take :) - is to narrow the issue to include only controls in controls. What do
you think?

-------------

PR: https://git.openjdk.java.net/jfx/pull/209