RFR: 8242523: Update the animation and clip envelope classes

[Kevin Rushforth]

On Wed, 13 May 2020 00:17:17 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/scenario/animation/shared/ClipEnvelope.java line 46:
>> 
>>> 45:  */
>>> 46: public abstract class ClipEnvelope {
>>> 47:
>> 
>> I think the removal of line 46 was unintended change.
>
> I think that there is no empty line between the docs and the declaration, but can revert.

Correct, so no need to revert.

>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line 142:
>> 
>>> 141:     }
>>> 142:
>>> 143:     /*
>> 
>> Both these methods seem like they belong to Utils.java. If moved to Utils.java then the all the calls
>> `(Math.abs(currentRate - rate) < EPSILON)` can be changed to use these methods from Utils.java. If we move these
>> methods then, Utils.java also needs to declare  `static final double EPSILON = 1e-12;`  and the EPSILON here can be
>> initialized as `private static final double EPSILON = Utils.EPSILON;`
>
> I agree that these methods are better suited there, but I'm not sure the same epsilon value will be suitable for other
> places that will want to use these. That value is somewhat arbitrary anyway I think.

Either is fine with me.

-------------

PR: https://git.openjdk.java.net/jfx/pull/196