RFR: 8242523: Update the animation and clip envelope classes

Ambarish Rapte arapte at openjdk.java.net
Thu May 14 05:50:40 UTC 2020


On Wed, 13 May 2020 12:29:03 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I agree that these methods are better suited there, but I'm not sure the same epsilon value will be suitable for other
>> places that will want to use these. That value is somewhat arbitrary anyway I think.
>
> Either is fine with me.

> but I'm not sure the same epsilon value will be suitable for other places that will want to use these

True, EPSILON is defined in some other classes with different value. Only Animation classes define EPSILON as 1e-12. So
it may not be reasonable to include Animation specific helper method in common Util class. These methods would be more
suitable for Animation only util class. I think I am good with the current way.

-------------

PR: https://git.openjdk.java.net/jfx/pull/196


More information about the openjfx-dev mailing list