RFR: 8256184: Openjfx build broken (Eclipse)

[Jeanette Winzenburg]

On Tue, 17 Nov 2020 09:26:32 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>>> 
>>> 
>>> I think that it should be fixed as part of this patch since it addresses exactly the same issue from the same cause.
>> 
>> perfectly valid (and what I would say as well ;) - but then I'm out - no intention to further fiddle with tooling that I'm not entirely confident with.
>
> Change the following in `\tests.classpath`:
> 
> 	<classpathentry combineaccessrules="false" kind="src" path="/base">
> 		<attributes>
> 			<attribute name="module" value="true"/>
> 			<attribute name="add-exports" value="javafx.base/com.sun.javafx=ALL-UNNAMED:javafx.base/test.util.memory=ALL-UNNAMED"/>
>                                                                                                ^ add here
> 		</attributes>
> 	</classpathentry>
> 
> See if these errors are resolved.

thanks, that's probably working :) Didn't try, though, because verifying does require to setup all modules as projects (which I don't have, not being interested in swing/web/fxml) Plus this extra effort would only fix the _current_ usage of memorybuddy, leaving future inclusions in the other modules still broken. 

So where to go from here:

- keep the scope of this issue focused on base/controls leaving the remaining projects to a new bug
- widen the scope of this bug to include all projects (current users as well as future users)

as you already rejected the first option, the second seems the way to go - that is, I will unassign the bug and close this PR?

-------------

PR: https://git.openjdk.java.net/jfx/pull/352