RFR: 8256184: Openjfx build broken (Eclipse)

[Nir Lisker]

On Tue, 17 Nov 2020 11:07:22 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Change the following in `\tests.classpath`:
>> 
>> 	<classpathentry combineaccessrules="false" kind="src" path="/base">
>> 		<attributes>
>> 			<attribute name="module" value="true"/>
>> 			<attribute name="add-exports" value="javafx.base/com.sun.javafx=ALL-UNNAMED:javafx.base/test.util.memory=ALL-UNNAMED"/>
>>                                                                                                ^ add here
>> 		</attributes>
>> 	</classpathentry>
>> 
>> See if these errors are resolved.
>
> thanks, that's probably working :) Didn't try, though, because verifying does require to setup all modules as projects (which I don't have, not being interested in swing/web/fxml) Plus this extra effort would only fix the _current_ usage of memorybuddy, leaving future inclusions in the other modules still broken. 
> 
> So where to go from here:
> 
> - keep the scope of this issue focused on base/controls leaving the remaining projects to a new bug
> - widen the scope of this bug to include all projects (current users as well as future users)
> 
> as you already rejected the first option, the second seems the way to go - that is, I will unassign the bug and close this PR?

> Plus this extra effort would only fix the current usage of memorybuddy, leaving future inclusions in the other modules still broken.

I think that this is fine. When future uses occur they should be accompanied by the inclusion of the dependency, unless we know of plans to use it in other modules. In any case, there is no need to close this PR.

-------------

PR: https://git.openjdk.java.net/jfx/pull/352