RFR: 8217472: Add attenuation for PointLight [v14]

Kevin Rushforth kcr at openjdk.java.net
Fri Oct 9 00:00:25 UTC 2020


On Thu, 24 Sep 2020 02:46:31 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change range after clamping

tests/system/src/test/java/test/javafx/scene/lighting3D/PointLightAttenuationTest.java line 65:

> 63:
> 64:     @BeforeClass
> 65:     public static void initFX() throws Exception {

One more thing I forgot to mention. You will need to skip the test if 3D is not supported using `assumeTrue`. See
[TriangleMeshValidationTest.java#L64](https://github.com/openjdk/jfx/blob/master/tests/system/src/test/java/test/robot/test3d/TriangleMeshValidationTest.java#L64).

-------------

PR: https://git.openjdk.java.net/jfx/pull/43


More information about the openjfx-dev mailing list