RFR: 8217472: Add attenuation for PointLight [v14]

Nir Lisker nlisker at openjdk.java.net
Fri Oct 9 01:32:25 UTC 2020


On Thu, 8 Oct 2020 22:20:17 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change range after clamping
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.cc line 49:
> 
>> 47:     attenuation[1] = 0;
>> 48:     attenuation[2] = 0;
>> 49:     maxRange = 0;
> 
> Same comment as in `NGShape3D` about using infinity here, although if this value is always set from the Java side, then
> this native default might not matter.

Yes, these values are always overridden.

-------------

PR: https://git.openjdk.java.net/jfx/pull/43


More information about the openjfx-dev mailing list