RFR: 8217472: Add attenuation for PointLight [v16]
Kevin Rushforth
kcr at openjdk.java.net
Fri Oct 9 18:15:13 UTC 2020
On Fri, 9 Oct 2020 16:33:28 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed test
tests/performance/3DLighting/attenuation/LightingSample.java line 72:
> 70: sphere.setOnAction(e -> switchTo(environment.createSphere((int) subdivisionSlider.getValue())));
> 71:
> 72: var quadSlider = new Slider(500, 10_000, 1000);
I was doing some final testing, and ran this on a few different systems. I think the min and max values are too large
(especially the min value). I recommend something more like min=100 and max=5000.
tests/performance/3DLighting/attenuation/LightingSample.java line 62:
> 60: environment.setStyle("-fx-background-color: teal");
> 61:
> 62: var subdivisionSlider = new Slider(10, 200, 60);
I might recommend setting the max value of the slider to something like 1000, since even on a slow system, it runs
quite nicely at that tessellation.
-------------
PR: https://git.openjdk.java.net/jfx/pull/43
More information about the openjfx-dev
mailing list