RFR: 8217472: Add attenuation for PointLight [v16]

Nir Lisker nlisker at openjdk.java.net
Mon Oct 19 17:59:20 UTC 2020


On Fri, 9 Oct 2020 18:11:14 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed test
>
> tests/performance/3DLighting/attenuation/LightingSample.java line 62:
> 
>> 60:         environment.setStyle("-fx-background-color: teal");
>> 61:
>> 62:         var subdivisionSlider = new Slider(10, 200, 60);
> 
> I might recommend setting the max value of the slider to something like 1000, since even on a slow system, it runs
> quite nicely at that tessellation.

I forgot to reply to this and the other comment. Since we're going to implement more light types, this small test app
is going to be updated anyway, so I will change the values then.

-------------

PR: https://git.openjdk.java.net/jfx/pull/43


More information about the openjfx-dev mailing list