RFR: 8255002: Many javafx.controls unit tests have incorrect name containing impl_* [v2]

Ajit Ghaisas aghaisas at openjdk.java.net
Wed Oct 21 11:54:25 UTC 2020


On Wed, 21 Oct 2020 08:23:25 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8255002 - review fixes
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTest.java line 73:
> 
>> 71:  *     - (2nd order) CssMetaData_isSettable returns true for thing in their default state
>> 72:  *     - (2nd order) CssMetaData_isSettable returns false for things manually specified
>> 73:  *     - (3rd order) impl_cssKeys includes all the public properties
> 
> I could not find a match for `impl_cssKeys`. Should it be considered in this fix ? either find a match and correct this comment or remove if it does not exist anymore. I don't have strong preference on this, I leave it to you.

I was in two minds whether to clean up these 3 commented references to "impl_".
Now, I have corrected two commented references where I could find the closest equivalents and deleted the third commented reference.

-------------

PR: https://git.openjdk.java.net/jfx/pull/326


More information about the openjfx-dev mailing list