RFR: 8264677 MemoryLeak: Progressindicator leaks, when treeShowing is false [v2]

[Ambarish Rapte]

On Tue, 6 Apr 2021 12:24:36 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Fixing leak in ProgressIndicator when treeShowing is false
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8264677
>   changes based on code review

Suggested a minor change.
The test file has an existing test `memoryTest()`. The `AfterClass` and `BeforeClass` methods are specific to this test, and not related to the new test. It looks little unstructured with addition of this new test. Not sure if it is worth to change the helper methods and existing test.
otherwise the fix and test looks good.

tests/system/src/test/java/test/javafx/scene/control/ProgressIndicatorLeakTest.java line 93:

> 91: 
> 92:     @Test
> 93:     public void treeNotShowing() throws Exception {

Minor: recommend changing name, may be  `stageLeakWhenTreeNotShowing`

-------------

PR: https://git.openjdk.java.net/jfx/pull/455