RFR: 8264677 MemoryLeak: Progressindicator leaks, when treeShowing is false [v2]

Florian Kirmaier fkirmaier at openjdk.java.net
Fri Apr 9 11:39:35 UTC 2021


On Wed, 7 Apr 2021 15:25:05 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8264677
>>   changes based on code review
>
> Suggested a minor change.
> The test file has an existing test `memoryTest()`. The `AfterClass` and `BeforeClass` methods are specific to this test, and not related to the new test. It looks little unstructured with addition of this new test. Not sure if it is worth to change the helper methods and existing test.
> otherwise the fix and test looks good.

I've now reworked the old test. The initialization of JavaFX is now seperated of the old test.
The old test is now also much simpler. It no longer "jumps around" between different methods.
The waiting for the Stage to be shown is also no longer necessary, which simplifies it even more.

-------------

PR: https://git.openjdk.java.net/jfx/pull/455


More information about the openjfx-dev mailing list