RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v3]
Kevin Rushforth
kcr at openjdk.java.net
Thu Apr 15 16:00:45 UTC 2021
On Thu, 15 Apr 2021 15:34:42 GMT, Johan Vos <jvos at openjdk.org> wrote:
>> Alexander Scherbatiy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add CONVERTED_OS_ARCH and CONVERTED_TARGET_ARCH variables
>
> build.gradle line 264:
>
>> 262: case "amd64" : return "x64"
>> 263: default: return arch
>> 264: }
>
> I think a function that gets the "converted" arch is very useful, but I'm not sure what the resulting value should be. In case of arm64/aarch64, I have s slight preference for aarch64, but I'm not against arm64.
This does seem useful, although in this case, wasn't `arm64` chosen for compatibility with the name in the Microsoft VisualStudio distro? If so, then this part of the most recent change might be Windows-specific. It might be better to revert this (going back to your previous fix in `win.gradle`) until we can take a more holistic look at this.
-------------
PR: https://git.openjdk.java.net/jfx/pull/439
More information about the openjfx-dev
mailing list