RFR: 8264064: Cross compile JavaFX graphics and controls modules for Windows AArch64 (ARM64) [v3]

Alexander Scherbatiy alexsch at openjdk.java.net
Thu Apr 15 17:46:34 UTC 2021


On Thu, 15 Apr 2021 15:57:32 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> build.gradle line 264:
>> 
>>> 262:         case "amd64" : return "x64"
>>> 263:         default: return arch
>>> 264:     }
>> 
>> I think a function that gets the "converted" arch is very useful, but I'm not sure what the resulting value should be. In case of arm64/aarch64, I have s slight preference for aarch64, but I'm not against arm64.
>
> This does seem useful, although in this case, wasn't `arm64` chosen for compatibility with the name in the Microsoft VisualStudio distro? If so, then this part of the most recent change might be Windows-specific. It might be better to revert this (going back to your previous fix in `win.gradle`) until we can take a more holistic look at this.

Yes, the arm64 is used as an OS arch for Visual Studio vcvarsall.bat and x64 as a part of a path to arch specific Visual Studio tools on Windows.

I reverted the fix with converted os arch variables back.

-------------

PR: https://git.openjdk.java.net/jfx/pull/439


More information about the openjfx-dev mailing list