RFR: 8264127: ListCell editing status is true, when index changes while editing [v8]

Jeanette Winzenburg fastegal at openjdk.java.net
Tue Apr 27 10:40:34 UTC 2021


On Tue, 27 Apr 2021 10:00:44 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

> 
> 
> I guess the different implementation in the different cells all have some subtle differences.
> 

actually, I doubt that they are different - my guess: we could formally prove that the logic is equivalent :) Or the other way: if they are, we should understand the differences. On first look your variant seems okay, as well.

> Then i guess we wait for the other review to finish. The change to use try finalize seems very very reasonable and important to me.

so we agree - will wait with a final review until the other is decided. You might consider removing the debug sysouts before that :)

-------------

PR: https://git.openjdk.java.net/jfx/pull/441


More information about the openjfx-dev mailing list