RFR: 8264127: ListCell editing status is true, when index changes while editing [v8]

[Florian Kirmaier]

On Tue, 27 Apr 2021 10:38:07 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> I've now rewritten the code. It's now way simpler and avoids duplicate code. I guess the different implementation in the different cells all have some subtle differences.
>> 
>> Then i guess we wait for the other review to finish. The change to use try finalize seems very very reasonable and important to me.
>
>> 
>> 
>> I guess the different implementation in the different cells all have some subtle differences.
>> 
> 
> actually, I doubt that they are different - my guess: we could formally prove that the logic is equivalent :) Or the other way: if they are, we should understand the differences. On first look your variant seems okay, as well.
> 
>> Then i guess we wait for the other review to finish. The change to use try finalize seems very very reasonable and important to me.
> 
> so we agree - will wait with a final review until the other is decided. You might consider removing the debug sysouts before that :)

Hm okay, when we assume the result of match in TreeCell is the same as index != editIndex, then they are identical.
And when we assume that cancelEdit doesn't have relevant side effects, which can easily happen due to various listeners ...

I've removed the accidentally commited print statements!

-------------

PR: https://git.openjdk.java.net/jfx/pull/441