RFR: 8267472: JavaFX modules to include version information [v2]

Christian Stein cstein at openjdk.java.net
Mon Aug 23 14:24:32 UTC 2021


On Mon, 23 Aug 2021 14:10:56 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> https://bugs.openjdk.java.net/browse/JDK-8267472
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Pass module version also to `jmod`

> I think there may be two other tasks where the --module-version is needed: :graphics:compileFullJava and :web:compileJavaDOMBindingTask.

So far to the "single place where Java module related options are found" argument.

Aren't they covered by the `allprojects { ... }` and

...
    // If I am a module....
    if (project.hasProperty('moduleSourcePath') &&
            (project.hasProperty('buildModule') && project.buildModule)) { ... }`
...
```  
...selector?

-------------

PR: https://git.openjdk.java.net/jfx/pull/608


More information about the openjfx-dev mailing list