RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v3]
eduardsdv
duke at openjdk.java.net
Fri Dec 10 15:24:45 UTC 2021
On Fri, 10 Dec 2021 15:00:56 GMT, Johan Vos <jvos at openjdk.org> wrote:
>> Without this line the test fails in the line 1865 with the message 'expected:<7> but was:<8>'.
>> I think this is because in the line 1850 'listView.scrollTo(99)' is executed, which now does not set the position to 1.
>>
>> It can also be caused by the https://bugs.openjdk.java.net/browse/JDK-8277785. When it is solved, this call will probably no longer be necessary.
>
> That is very well possible indeed. Since we estimate the size of the different cells, it is hard to deterministically put values on the counts. Therefor, I changed a number of tests from `equals` to `<` . I would personally suggest not adding the `pulse` here, but rather change the test in line 1865 with `... < 10 ` to make sure that there is no abnormal amount of processing. (and maybe also `> 0 ` to make sure that the updateItem is at least counted once).
I removed the Toolkit.getToolkit().firePulse() and adjusted the expected values in the test.
-------------
PR: https://git.openjdk.java.net/jfx/pull/656
More information about the openjfx-dev
mailing list