RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v3]

Kevin Rushforth kcr at openjdk.java.net
Fri Dec 10 23:51:17 UTC 2021


On Fri, 10 Dec 2021 14:58:25 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> This part was originally copied from the 'VirtualContainerBase'. There was this comment: _special-case the 'greater than row count' condition to have it be perfectly at position 1_.
>> 
>> Maybe to avoid throwing the IndexOutOfBoundsException or simply to scroll to the end.
>
> I am ok with this behavior, but then it should be specified in the javadoc for `@parameter index` that the value can be greater than row count, and that in that case the view will be positioned at the very end.
> @kevinrushforth do you have an opinion on this?
> This is unrelated to the current fix, so that should not stop this PR.

This seems reasonable to me, too. And I agree that it should be specified via a follow-up issue, which will need a CSR.

-------------

PR: https://git.openjdk.java.net/jfx/pull/656


More information about the openjfx-dev mailing list