RFR: 8197991: Selecting many items in a TableView is very slow [v3]
Kevin Rushforth
kcr at openjdk.java.net
Fri Dec 17 22:18:26 UTC 2021
On Fri, 26 Nov 2021 19:49:37 GMT, Abhinay Agarwal <duke at openjdk.java.net> wrote:
>> This work improves the performance of `MultipleSelectionModel` over large data sets by caching some values and avoiding unnecessary calls to `SelectedIndicesList#size`. It further improves the performance by reducing the number of iterations required to find the index of an element in the BitSet.
>>
>> The work is based on [an abandoned patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs
>>
>> There are currently 2 manual tests for this fix.
>
> Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision:
>
> Update ROW_COUNT to 700_000
Thanks for adding the manual test. I can confirm the performance gains. I ran the ListView test, clicked on one of the cells visible without scrolling, then pressed the "select to the end" operation. With the 70k cells defined by the test program that operation ran 13,715 times faster on my machine with this fix.
-------------
PR: https://git.openjdk.java.net/jfx/pull/673
More information about the openjfx-dev
mailing list