RFR: 8197991: Selecting many items in a TableView is very slow [v3]

Abhinay Agarwal duke at openjdk.java.net
Tue Dec 21 12:13:17 UTC 2021


On Fri, 17 Dec 2021 19:18:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Abhinay Agarwal has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update ROW_COUNT to 700_000
>
> modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java line 880:
> 
>> 878:         @Override public int indexOf(Object obj) {
>> 879:             reset();
>> 880:             return super.indexOf(obj);
> 
> So `reset` doesn't need to still be called?

`reset()` was previously called since `super.indexof()` was making calls to `get(int index)` and it needed to have `lastGetIndex` and `lastGetValue` set to -1

-------------

PR: https://git.openjdk.java.net/jfx/pull/673


More information about the openjfx-dev mailing list