RFR: 8255572: Axis does not compute preferred height properly when autoRanging is off [v3]
Jeanette Winzenburg
fastegal at openjdk.java.net
Tue Feb 2 13:17:44 UTC 2021
On Tue, 22 Dec 2020 09:32:36 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:
>
>
> At first, I thought this setTickLabelRotation() call violates the method javadoc above. On a second look, I found that the javadoc is applicable only if AutoRanging() is true.
> Method calls - calculateNewSpacing() and calculateNewFirstPos() also set properties if AutoRanging is false. Hence, this fix seems OK to me.
hmm ... indeed they do, unexpected for me, reading the must-not-effect-the-state in the javadoc ;) Sounds like a doc error, if the intention was to clearly state that the method shouldn't do the auto-ranging itself?
-------------
PR: https://git.openjdk.java.net/jfx/pull/342
More information about the openjfx-dev
mailing list