RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners

[Kevin Rushforth]

On Mon, 22 Feb 2021 14:58:45 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange listeners in the same way as changeListeners
> - added java doc 
> - added tests
> 
> Changes in SkinBase
> - added api (and implementation delegating to the handler)
> - copied java doc from the change listener un/register methods 
> - added tests to verify that the new (and old) api is indeed delegating to the handler
> 
> Note that the null handling is slightly extended: all methods now can handle both null consumers (as before) and null observables (new) - this allows simplified code on rewiring "path" properties (see reference example in the issue)

Not yet reviewed. All of the new API methods need to have an `@since 17` javadoc tag.

modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line 250:

> 248:      * @param observable the observable to observe for invalidation events
> 249:      * @param consumer the consumer
> 250:      */

Add `@since 17` javadoc tag.

modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line 269:

> 267:      *      {@link #registerInvalidationListener(Observable, Consumer)}. If no consumers have been registered on this
> 268:      *      property, null will be returned.
> 269:      * @since 9

Need to change `9` to `17`.

modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line 285:

> 283:      * @param observableList the observable list to observe for list change events
> 284:      * @param consumer the consumer
> 285:      */

Add `@since 17` javadoc tag.

modules/javafx.controls/src/main/java/javafx/scene/control/SkinBase.java line 305:

> 303:      *      {@link #registerListChangeListener(ObservableList, Consumer)}. If no consumers have been registered on this
> 304:      *      list, null will be returned.
> 305:      * @since 9

Need to change `9` to `17`.

-------------

PR: https://git.openjdk.java.net/jfx/pull/409